Tidy up forms.

[readifood.git] / lib / hub.php

diff --git a/lib/hub.php b/lib/hub.php
index 48b45ae..79051f8 100644 (file)
--- a/lib/hub.php
+++ b/lib/hub.php
@@ -40,18 +40,28 @@
     exit;
   }
 
+  function show_hub_summary(&$hub, $editing = false) {
+    if ($editing) echo "<p>Hub: <span class=\"strong\">" . htmlspecialchars($hub->getName()) . "</span>";
+    else echo "<br>\nHub " . $hub->getStrongLink();
+    $role = $hub->getRole();
+    $role_string = get_hub_role_string($hub);
+    if ($role_string) echo " $role_string";
+    if ($role & $GLOBALS['ROLE_COLLECTION']) printf(" <a class=\"small\" href=\"/donation/to/hub/%s/%d\">Donations</a>", urlencode($hub->getName()), $hub->getId());
+    if ($role & $GLOBALS['ROLE_DISTRIBUTION']) printf(" <a class=\"small\" href=\"/order/to/hub/%s/%d\">Orders</a>", urlencode($hub->getName()), $hub->getId());
+    if (check_admin(1)) {
+      echo " " . $hub->getDeleteLink();
+    }
+    $area = get_hub_area($hub);
+    if ($area) echo " in " . $area->getLink();
+    $city = get_hub_city($hub);
+    if ($city) echo ", " . $city->getLink(get_city_displayname($city));
+  }
+
   function show_hubs($offset, $per_page, $address_ids) {
     $q = new HubQuery;
     $hubs = $q->filterByAddressId($address_ids)->find();
     if (count($hubs)) {
-      foreach ($hubs as $hub) {
-        echo "<br>\nhub " . $hub->getLink();
-        if (check_admin(1)) {
-          echo " " . $hub->getDeleteLink();
-        }
-        $area = get_hub_area($hub);
-        echo " in " . $area->getLink();
-      }
+      foreach ($hubs as $hub) show_hub_summary($hub);
     }
     else echo " none";
   }
@@ -70,7 +80,7 @@
       $address_ids = array();
       foreach ($addresses as $address) $address_ids[] = $address->getId();
 
-      echo "<p>hubs in city " . $city->getLink(get_city_displayname($city)) . ":";
+      echo "<p>Hubs in city " . $city->getLink(get_city_displayname($city)) . ":";
       return show_hubs($offset, $per_page, $address_ids);
     }
     else echo "<p>No such city!</p>\n";
@@ -98,7 +108,6 @@
       return;
     }
 
-    echo "<form method=\"POST\" action=\"" . $_SERVER['REQUEST_URI'] . "\">\n";
     echo "<p>Show hubs in area\n";
     echo "<select name=\"area_id\">\n";
     foreach ($areas as $area) {
@@ -106,7 +115,6 @@
     }
     echo "</select>\n";
     echo "<input type=\"submit\" value=\"Show\">\n";
-    echo "</form>\n";
   }
 
   function show_hub_cities_form($city_id = null) {
@@ -118,7 +126,6 @@
       return;
     }
 
-    echo "<form method=\"POST\" action=\"" . $_SERVER['REQUEST_URI'] . "\">\n";
     echo "<p>Show hubs in city\n";
     echo "<select name=\"city_id\">\n";
     foreach ($cities as $city) {
@@ -126,17 +133,28 @@
     }
     echo "</select>\n";
     echo "<input type=\"submit\" value=\"Show\">\n";
-    echo "</form>\n";
   }
 
   function show_hub_forms($city_id) {
+    form("noprint standout");
     show_hub_areas_form($city_id);
     show_hub_cities_form($city_id);
+    end_form();
+  }
+
+  function show_hub_role_form($role) {
+    return show_role_form($role, $GLOBALS['hub_roles']);
   }
 
   function show_hub_form($hub = null, $area_id = null) {
     if (! $hub) $hub = new Hub;
 
+    /* Role. */
+    echo "<tr>\n";
+    echo "  <td>Role</td>\n";
+    echo "  <td>"; show_hub_role_form($hub->getRole()); echo "</td>\n";
+    echo "</tr>\n";
+
     /* Display name. */
     echo "<tr>\n";
     echo "  <td>Hub name</td>\n";
@@ -195,7 +213,7 @@
       return;
     }
 
-    echo "<form method=\"POST\" action=\"" . $_SERVER['REQUEST_URI'] . "\">\n";
+    form("noprint");
     echo "<p>Add a new hub:</p>\n";
 
     echo "<table>\n";
@@ -205,7 +223,7 @@
     echo "  <td colspan=2>"; submit("add_hub", "Add"); echo "</td></tr>\n";
     echo "</tr>\n";
     echo "</table>\n";
-    echo "</form>\n";
+    end_form();
   }
 
   function show_add_new_hub_form() {
@@ -218,7 +236,7 @@
       return;
     }
 
-    echo "<form method=\"POST\" action=\"" . $_SERVER['REQUEST_URI'] . "\">\n";
+    form("noprint standout");
     echo "<p>Add a new hub in <select name=\"city_id\">\n";
     foreach ($cities as $city) {
       option("city_id", $city->getId(), get_city_displayname($city));
@@ -226,10 +244,17 @@
     echo "</select>";
     submit("show_add_hub", "Proceed");
     echo "</p>\n";
-    echo "</form>\n";
+    end_form();
   }
 
   function update_hub(&$hub, $area_id, $new = false) {
+    global $hub_roles;
+
+    $role = 0;
+    for ($i = 0; $i < count($hub_roles); $i++) {
+      if ($_POST['role_' . $i] == "on") $role |= (1 << $i);
+    }
+
     $displayname = $_POST['displayname'];
 
     if (! $displayname) {
@@ -264,6 +289,7 @@
     $telephone2 = $_POST['telephone2'];
     $email = $_POST['email'];
 
+    $hub->setRole($role);
     $hub->setDisplayname($displayname);
     $hub->setTelephone1($telephone1);
     $hub->setTelephone2($telephone2);
@@ -329,13 +355,8 @@
     else $hub = get_hub_by_name($name);
     if (! $hub) return;
 
-    echo "<form method=\"POST\" action=\"" . $_SERVER['REQUEST_URI'] . "\">\n";
-    echo "<p>Hub: <span class=\"strong\">" . $hub->getDisplayname() . "</span>";
-    if (check_admin(1)) {
-      echo " " . $hub->getDeleteLink();
-    }
-    $city = get_hub_city($hub);
-    if ($city) echo " in " . $city->getLink(get_city_displayname($city));
+    form();
+    show_hub_summary($hub, true);
     echo ": ";
     echo "\n</p>";
 
@@ -351,7 +372,7 @@
     }
 
     echo "</table>\n";
-    echo "</form>\n";
+    end_form();
   }
 
   /* /hub/in/area/Cambridge/1 */
@@ -376,8 +397,6 @@
           show_city_hubs(0, 10, $parameters[2], $city_id);
         break;
       }
-
-      show_new_hub_form($city_id);
     }
   }
   list($name, $id, $args) = parse_parameters($parameters);
@@ -390,14 +409,8 @@
     }
   }
   else if (isset($name)) show_hub($name, $id);
-  else {
-    /* XXX: Shown after adding. */
-    show_hub_forms($city_id);
-    show_add_new_hub_form($city_id);
-  }
 
-  if (count($parameters)) {
-    show_hub_forms($city_id);
-  }
+  show_hub_forms($city_id);
+  show_add_new_hub_form($city_id);
 
 ?>