From 7f60a4c99c695b229e956a758b4bc29fc84b4ed4 Mon Sep 17 00:00:00 2001 From: Iain Patterson Date: Mon, 22 Feb 2016 13:15:44 +0000 Subject: [PATCH] EventMessageFile should be unquoted. We were writing a quoted message source path to the registry. Stefan and Michael Scherer point out that it should be unquoted. --- README.txt | 1 + registry.cpp | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/README.txt b/README.txt index d78d854..02306e5 100644 --- a/README.txt +++ b/README.txt @@ -879,6 +879,7 @@ the registry for parameters. Thanks to Gerald Haider for noticing that installing a service with NSSM in a path containing spaces was technically a security vulnerability. Thanks to Scott Ware for reporting a crash saving the environment on XP 32-bit. +Thanks to Stefan and Michael Scherer for reporting a bug writing the event messages source. Licence ------- diff --git a/registry.cpp b/registry.cpp index c0ba8f1..20033f8 100644 --- a/registry.cpp +++ b/registry.cpp @@ -50,7 +50,7 @@ int create_messages() { } /* Get path of this program */ - const TCHAR *path = nssm_imagepath(); + const TCHAR *path = nssm_unquoted_imagepath(); /* Try to register the module but don't worry so much on failure */ RegSetValueEx(key, _T("EventMessageFile"), 0, REG_SZ, (const unsigned char *) path, (unsigned long) (_tcslen(path) + 1) * sizeof(TCHAR)); -- 2.7.4