From: Iain Patterson <me@iain.cx>
Date: Sun, 24 Nov 2013 20:35:18 +0000 (+0000)
Subject: Fixed parameters bug when installing from the GUI.
X-Git-Tag: v2.21~1
X-Git-Url: http://git.iain.cx/?p=nssm.git;a=commitdiff_plain;h=1d02256aa5bba3f3fd752c199adf77141428445f

Fixed parameters bug when installing from the GUI.

We were calling GetDlgItemText() on the wrong window.  As a result,
trying to install a sevice with parameters set would fail with the
error message "No valid options were specified!"
---

diff --git a/ChangeLog.txt b/ChangeLog.txt
index 08188a6..e50c841 100644
--- a/ChangeLog.txt
+++ b/ChangeLog.txt
@@ -1,3 +1,8 @@
+Changes since 2.20
+-----------------
+  * Services installed from the GUI no longer have incorrect
+    AppParameters set in the registry.
+
 Changes since 2.19
 -----------------
   * Services installed from the commandline without using the
diff --git a/README.txt b/README.txt
index 3480fa9..b3742bf 100644
--- a/README.txt
+++ b/README.txt
@@ -324,6 +324,7 @@ on shutdown.
 Thanks to Brian Baxter for suggesting how to escape quotes from the command prompt.
 Thanks to Russ Holmann for suggesting that the shutdown timeout be configurable.
 Thanks to Paul Spause for spotting a bug with default registry entries.
+Thanks to BUGHUNTER for spotting more GUI bugs.
 
 Licence
 -------
diff --git a/gui.cpp b/gui.cpp
index ca21ace..9c5c57d 100644
--- a/gui.cpp
+++ b/gui.cpp
@@ -110,7 +110,7 @@ int install(HWND window) {
 
     /* Get flags. */
     if (SendMessage(GetDlgItem(tablist[NSSM_TAB_APPLICATION], IDC_FLAGS), WM_GETTEXTLENGTH, 0, 0)) {
-      if (! GetDlgItemText(window, IDC_FLAGS, service->flags, sizeof(service->flags))) {
+      if (! GetDlgItemText(tablist[NSSM_TAB_APPLICATION], IDC_FLAGS, service->flags, sizeof(service->flags))) {
         popup_message(MB_OK | MB_ICONEXCLAMATION, NSSM_GUI_INVALID_OPTIONS);
         return 4;
       }