Allow editing services.
[nssm.git] / service.cpp
index 09fbe1f..b246443 100644 (file)
@@ -1,5 +1,7 @@
 #include "nssm.h"\r
 \r
+extern const TCHAR *exit_action_strings[];\r
+\r
 bool is_admin;\r
 bool use_critical_section;\r
 \r
@@ -120,6 +122,172 @@ int pre_install_service(int argc, TCHAR **argv) {
   return ret;\r
 }\r
 \r
+/* About to edit the service. */\r
+int pre_edit_service(int argc, TCHAR **argv) {\r
+  /* Require service name. */\r
+  if (argc < 1) return usage(1);\r
+\r
+  nssm_service_t *service = alloc_nssm_service();\r
+  _sntprintf_s(service->name, _countof(service->name), _TRUNCATE, _T("%s"), argv[0]);\r
+\r
+  /* Open service manager */\r
+  SC_HANDLE services = open_service_manager();\r
+  if (! services) {\r
+    print_message(stderr, NSSM_MESSAGE_OPEN_SERVICE_MANAGER_FAILED);\r
+    return 2;\r
+  }\r
+\r
+  /* Try to open the service */\r
+  service->handle = OpenService(services, service->name, SC_MANAGER_ALL_ACCESS);\r
+  if (! service->handle) {\r
+    CloseServiceHandle(services);\r
+    print_message(stderr, NSSM_MESSAGE_OPENSERVICE_FAILED);\r
+    return 3;\r
+  }\r
+\r
+  /* Get system details. */\r
+  unsigned long bufsize;\r
+  unsigned long error;\r
+  QUERY_SERVICE_CONFIG *qsc;\r
+\r
+  QueryServiceConfig(service->handle, 0, 0, &bufsize);\r
+  error = GetLastError();\r
+  if (error == ERROR_INSUFFICIENT_BUFFER) {\r
+    qsc = (QUERY_SERVICE_CONFIG *) HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, bufsize);\r
+    if (! qsc) {\r
+      print_message(stderr, NSSM_EVENT_OUT_OF_MEMORY, _T("QUERY_SERVICE_CONFIG"), _T("pre_edit_service()"), 0);\r
+      return 4;\r
+    }\r
+  }\r
+  else {\r
+    CloseHandle(service->handle);\r
+    CloseServiceHandle(services);\r
+    print_message(stderr, NSSM_MESSAGE_QUERYSERVICECONFIG_FAILED, service->name, error_string(error), 0);\r
+    return 4;\r
+  }\r
+\r
+  if (! QueryServiceConfig(service->handle, qsc, bufsize, &bufsize)) {\r
+    HeapFree(GetProcessHeap(), 0, qsc);\r
+    CloseHandle(service->handle);\r
+    CloseServiceHandle(services);\r
+    print_message(stderr, NSSM_MESSAGE_QUERYSERVICECONFIG_FAILED, service->name, error_string(GetLastError()), 0);\r
+    return 4;\r
+  }\r
+\r
+  service->type = qsc->dwServiceType;\r
+  if (! (service->type & SERVICE_WIN32_OWN_PROCESS)) {\r
+    HeapFree(GetProcessHeap(), 0, qsc);\r
+    CloseHandle(service->handle);\r
+    CloseServiceHandle(services);\r
+    print_message(stderr, NSSM_MESSAGE_CANNOT_EDIT, service->name, _T("SERVICE_WIN32_OWN_PROCESS"), 0);\r
+    return 3;\r
+  }\r
+\r
+  switch (qsc->dwStartType) {\r
+    case SERVICE_DEMAND_START: service->startup = NSSM_STARTUP_MANUAL; break;\r
+    case SERVICE_DISABLED: service->startup = NSSM_STARTUP_DISABLED; break;\r
+    default: service->startup = NSSM_STARTUP_AUTOMATIC;\r
+  }\r
+  if (! str_equiv(qsc->lpServiceStartName, NSSM_LOCALSYSTEM_ACCOUNT)) {\r
+    size_t len = _tcslen(qsc->lpServiceStartName);\r
+    service->username = (TCHAR *) HeapAlloc(GetProcessHeap(), 0, (len + 1) * sizeof(TCHAR));\r
+    if (service->username) {\r
+      memmove(service->username, qsc->lpServiceStartName, (len + 1) * sizeof(TCHAR));\r
+      service->usernamelen = (unsigned long) len;\r
+    }\r
+    else {\r
+      HeapFree(GetProcessHeap(), 0, qsc);\r
+      CloseHandle(service->handle);\r
+      CloseServiceHandle(services);\r
+      print_message(stderr, NSSM_EVENT_OUT_OF_MEMORY, _T("username"), _T("pre_edit_service()"));\r
+      return 4;\r
+    }\r
+  }\r
+  _sntprintf_s(service->displayname, _countof(service->displayname), _TRUNCATE, _T("%s"), qsc->lpDisplayName);\r
+\r
+  /* Remember the executable in case it isn't NSSM. */\r
+  _sntprintf_s(service->image, _countof(service->image), _TRUNCATE, _T("%s"), qsc->lpBinaryPathName);\r
+  HeapFree(GetProcessHeap(), 0, qsc);\r
+\r
+  /* Get extended system details. */\r
+  if (service->startup == NSSM_STARTUP_AUTOMATIC) {\r
+    QueryServiceConfig2(service->handle, SERVICE_CONFIG_DELAYED_AUTO_START_INFO, 0, 0, &bufsize);\r
+    error = GetLastError();\r
+    if (error == ERROR_INSUFFICIENT_BUFFER) {\r
+      SERVICE_DELAYED_AUTO_START_INFO *info = (SERVICE_DELAYED_AUTO_START_INFO *) HeapAlloc(GetProcessHeap(), 0, bufsize);\r
+      if (! info) {\r
+        CloseHandle(service->handle);\r
+        CloseServiceHandle(services);\r
+        print_message(stderr, NSSM_EVENT_OUT_OF_MEMORY, _T("SERVICE_DELAYED_AUTO_START_INFO"), _T("pre_edit_service()"));\r
+        return 5;\r
+      }\r
+\r
+      if (QueryServiceConfig2(service->handle, SERVICE_CONFIG_DELAYED_AUTO_START_INFO, (unsigned char *) info, bufsize, &bufsize)) {\r
+        if (info->fDelayedAutostart) service->startup = NSSM_STARTUP_DELAYED;\r
+      }\r
+      else {\r
+        error = GetLastError();\r
+        if (error != ERROR_INVALID_LEVEL) {\r
+          CloseHandle(service->handle);\r
+          CloseServiceHandle(services);\r
+          print_message(stderr, NSSM_MESSAGE_QUERYSERVICECONFIG2_FAILED, service->name, _T("SERVICE_CONFIG_DELAYED_AUTO_START_INFO"), error_string(error));\r
+          return 5;\r
+        }\r
+      }\r
+    }\r
+    else if (error != ERROR_INVALID_LEVEL) {\r
+      CloseHandle(service->handle);\r
+      CloseServiceHandle(services);\r
+      print_message(stderr, NSSM_MESSAGE_QUERYSERVICECONFIG2_FAILED, service->name, _T("SERVICE_DELAYED_AUTO_START_INFO"), error_string(error));\r
+      return 5;\r
+    }\r
+  }\r
+\r
+  QueryServiceConfig2(service->handle, SERVICE_CONFIG_DESCRIPTION, 0, 0, &bufsize);\r
+  error = GetLastError();\r
+  if (error == ERROR_INSUFFICIENT_BUFFER) {\r
+    SERVICE_DESCRIPTION *description = (SERVICE_DESCRIPTION *) HeapAlloc(GetProcessHeap(), 0, bufsize);\r
+    if (! description) {\r
+      CloseHandle(service->handle);\r
+      CloseServiceHandle(services);\r
+      print_message(stderr, NSSM_EVENT_OUT_OF_MEMORY, _T("SERVICE_CONFIG_DESCRIPTION"), _T("pre_edit_service()"));\r
+      return 6;\r
+    }\r
+\r
+    if (QueryServiceConfig2(service->handle, SERVICE_CONFIG_DESCRIPTION, (unsigned char *) description, bufsize, &bufsize)) {\r
+     if (description->lpDescription) _sntprintf_s(service->description, _countof(service->description), _TRUNCATE, _T("%s"), description->lpDescription);\r
+      HeapFree(GetProcessHeap(), 0, description);\r
+    }\r
+    else {\r
+      HeapFree(GetProcessHeap(), 0, description);\r
+      CloseHandle(service->handle);\r
+      CloseServiceHandle(services);\r
+      print_message(stderr, NSSM_MESSAGE_QUERYSERVICECONFIG2_FAILED, service->name, _T("SERVICE_CONFIG_DELAYED_AUTO_START_INFO"), error_string(error));\r
+      return 6;\r
+    }\r
+  }\r
+  else {\r
+    CloseHandle(service->handle);\r
+    CloseServiceHandle(services);\r
+    print_message(stderr, NSSM_MESSAGE_QUERYSERVICECONFIG2_FAILED, service->name, _T("SERVICE_CONFIG_DELAYED_AUTO_START_INFO"), error_string(error));\r
+    return 6;\r
+  }\r
+\r
+  /* Get NSSM details. */\r
+  get_parameters(service, 0);\r
+\r
+  CloseServiceHandle(services);\r
+\r
+  if (! service->exe[0]) {\r
+    print_message(stderr, NSSM_MESSAGE_INVALID_SERVICE, service->name, NSSM, service->image);\r
+    service->native = true;\r
+  }\r
+\r
+  nssm_gui(IDD_EDIT, service);\r
+\r
+  return 0;\r
+}\r
+\r
 /* About to remove the service */\r
 int pre_remove_service(int argc, TCHAR **argv) {\r
   nssm_service_t *service = alloc_nssm_service();\r
@@ -150,8 +318,33 @@ int install_service(nssm_service_t *service) {
   }\r
 \r
   /* Get path of this program */\r
-  TCHAR command[MAX_PATH];\r
-  GetModuleFileName(0, command, _countof(command));\r
+  GetModuleFileName(0, service->image, _countof(service->image));\r
+\r
+  /* Create the service - settings will be changed in edit_service() */\r
+  service->handle = CreateService(services, service->name, service->name, SC_MANAGER_ALL_ACCESS, SERVICE_WIN32_OWN_PROCESS, SERVICE_AUTO_START, SERVICE_ERROR_NORMAL, service->image, 0, 0, 0, 0, 0);\r
+  if (! service->handle) {\r
+    print_message(stderr, NSSM_MESSAGE_CREATESERVICE_FAILED);\r
+    CloseServiceHandle(services);\r
+    return 5;\r
+  }\r
+\r
+  if (edit_service(service, false)) {\r
+    DeleteService(service->handle);\r
+    CloseServiceHandle(services);\r
+    return 6;\r
+  }\r
+\r
+  print_message(stdout, NSSM_MESSAGE_SERVICE_INSTALLED, service->name);\r
+\r
+  /* Cleanup */\r
+  CloseServiceHandle(services);\r
+\r
+  return 0;\r
+}\r
+\r
+/* Edit the service. */\r
+int edit_service(nssm_service_t *service, bool editing) {\r
+  if (! service) return 1;\r
 \r
   /*\r
     The only two valid flags for service type are SERVICE_WIN32_OWN_PROCESS\r
@@ -171,51 +364,59 @@ int install_service(nssm_service_t *service) {
   /* Display name. */\r
   if (! service->displayname[0]) _sntprintf_s(service->displayname, _countof(service->displayname), _TRUNCATE, _T("%s"), service->name);\r
 \r
-  /* Create the service */\r
-  service->handle = CreateService(services, service->name, service->displayname, SC_MANAGER_ALL_ACCESS, service->type, startup, SERVICE_ERROR_NORMAL, command, 0, 0, 0, service->username, service->password);\r
-  if (! service->handle) {\r
-    print_message(stderr, NSSM_MESSAGE_CREATESERVICE_FAILED);\r
-    CloseServiceHandle(services);\r
+  /*\r
+    Username must be NULL if we aren't changing or an account name.\r
+    We must explicitly user LOCALSYSTEM to change it when we are editing.\r
+    Password must be NULL if we aren't changing, a password or "".\r
+    Empty passwords are valid but we won't allow them in the GUI.\r
+  */\r
+  TCHAR *username = 0;\r
+  TCHAR *password = 0;\r
+  if (service->usernamelen) {\r
+    username = service->username;\r
+    if (service->passwordlen) password = service->password;\r
+    else password = _T("");\r
+  }\r
+  else if (editing) username = NSSM_LOCALSYSTEM_ACCOUNT;\r
+\r
+  if (! ChangeServiceConfig(service->handle, service->type, startup, SERVICE_NO_CHANGE, 0, 0, 0, 0, username, password, service->displayname)) {\r
+    print_message(stderr, NSSM_MESSAGE_CHANGESERVICECONFIG_FAILED, error_string(GetLastError()));\r
     return 5;\r
   }\r
 \r
-  if (service->description[0]) {\r
+  if (service->description[0] || editing) {\r
     SERVICE_DESCRIPTION description;\r
     ZeroMemory(&description, sizeof(description));\r
-    description.lpDescription = service->description;\r
+    if (service->description[0]) description.lpDescription = service->description;\r
+    else description.lpDescription = 0;\r
     if (! ChangeServiceConfig2(service->handle, SERVICE_CONFIG_DESCRIPTION, &description)) {\r
       log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_SERVICE_CONFIG_DESCRIPTION_FAILED, service->name, error_string(GetLastError()), 0);\r
     }\r
   }\r
 \r
-  if (service->startup == NSSM_STARTUP_DELAYED) {\r
-    SERVICE_DELAYED_AUTO_START_INFO delayed;\r
-    ZeroMemory(&delayed, sizeof(delayed));\r
-    delayed.fDelayedAutostart = 1;\r
-    /* Delayed startup isn't supported until Vista. */\r
-    if (! ChangeServiceConfig2(service->handle, SERVICE_CONFIG_DELAYED_AUTO_START_INFO, &delayed)) {\r
-      unsigned long error = GetLastError();\r
-      /* Pre-Vista we expect to fail with ERROR_INVALID_LEVEL */\r
-      if (error != ERROR_INVALID_LEVEL) {\r
-        log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_SERVICE_CONFIG_DELAYED_AUTO_START_INFO_FAILED, service->name, error_string(error), 0);\r
-      }\r
+  SERVICE_DELAYED_AUTO_START_INFO delayed;\r
+  ZeroMemory(&delayed, sizeof(delayed));\r
+  if (service->startup == NSSM_STARTUP_DELAYED) delayed.fDelayedAutostart = 1;\r
+  else delayed.fDelayedAutostart = 0;\r
+  /* Delayed startup isn't supported until Vista. */\r
+  if (! ChangeServiceConfig2(service->handle, SERVICE_CONFIG_DELAYED_AUTO_START_INFO, &delayed)) {\r
+    unsigned long error = GetLastError();\r
+    /* Pre-Vista we expect to fail with ERROR_INVALID_LEVEL */\r
+    if (error != ERROR_INVALID_LEVEL) {\r
+      log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_SERVICE_CONFIG_DELAYED_AUTO_START_INFO_FAILED, service->name, error_string(error), 0);\r
     }\r
   }\r
 \r
-  /* Now we need to put the parameters into the registry */\r
-  if (create_parameters(service)) {\r
-    print_message(stderr, NSSM_MESSAGE_CREATE_PARAMETERS_FAILED);\r
-    DeleteService(service->handle);\r
-    CloseServiceHandle(services);\r
-    return 6;\r
-  }\r
-\r
-  set_service_recovery(service);\r
-\r
-  print_message(stdout, NSSM_MESSAGE_SERVICE_INSTALLED, service->name);\r
+  /* Don't mess with parameters which aren't ours. */\r
+  if (! service->native) {\r
+    /* Now we need to put the parameters into the registry */\r
+    if (create_parameters(service, editing)) {\r
+      print_message(stderr, NSSM_MESSAGE_CREATE_PARAMETERS_FAILED);\r
+      return 6;\r
+    }\r
 \r
-  /* Cleanup */\r
-  CloseServiceHandle(services);\r
+    set_service_recovery(service);\r
+  }\r
 \r
   return 0;\r
 }\r
@@ -295,7 +496,7 @@ void WINAPI service_main(unsigned long argc, TCHAR **argv) {
 \r
   if (is_admin) {\r
     /* Try to create the exit action parameters; we don't care if it fails */\r
-    create_exit_action(service->name, exit_action_strings[0]);\r
+    create_exit_action(service->name, exit_action_strings[0], false);\r
 \r
     SC_HANDLE services = open_service_manager();\r
     if (services) {\r