X-Git-Url: http://git.iain.cx/?a=blobdiff_plain;f=registry.cpp;h=7eb6112d5e90a6c1617eaac443496063363806c1;hb=636b16d3702049145143511c6461ff20bf1f245d;hp=fbcc36951781e124e03613d1e4d8a0417bf20c31;hpb=ce9eb5d4646a0e279eae2909a18fccb1197e15fb;p=nssm.git diff --git a/registry.cpp b/registry.cpp index fbcc369..7eb6112 100644 --- a/registry.cpp +++ b/registry.cpp @@ -219,7 +219,27 @@ int get_number(HKEY key, char *value, unsigned long *number) { return get_number(key, value, number, true); } -int get_parameters(char *service_name, char *exe, unsigned long exelen, char *flags, unsigned long flagslen, char *dir, unsigned long dirlen, char **env, unsigned long *throttle_delay, unsigned long *stop_method, STARTUPINFO *si) { +void override_milliseconds(char *service_name, HKEY key, char *value, unsigned long *buffer, unsigned long default_value, unsigned long event) { + unsigned long type = REG_DWORD; + unsigned long buflen = sizeof(unsigned long); + bool ok = false; + unsigned long ret = RegQueryValueEx(key, value, 0, &type, (unsigned char *) buffer, &buflen); + if (ret != ERROR_SUCCESS) { + if (ret != ERROR_FILE_NOT_FOUND) { + if (type != REG_DWORD) { + char milliseconds[16]; + _snprintf_s(milliseconds, sizeof(milliseconds), _TRUNCATE, "%lu", default_value); + log_event(EVENTLOG_WARNING_TYPE, event, service_name, value, milliseconds, 0); + } + else log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_QUERYVALUE_FAILED, value, error_string(GetLastError()), 0); + } + } + else ok = true; + + if (! ok) *buffer = default_value; +} + +int get_parameters(char *service_name, char *exe, unsigned long exelen, char *flags, unsigned long flagslen, char *dir, unsigned long dirlen, char **env, unsigned long *throttle_delay, unsigned long *stop_method, unsigned long *kill_console_delay, unsigned long *kill_window_delay, unsigned long *kill_threads_delay, STARTUPINFO *si) { unsigned long ret; /* Get registry */ @@ -280,28 +300,12 @@ int get_parameters(char *service_name, char *exe, unsigned long exelen, char *fl } /* Try to get throttle restart delay */ - unsigned long type = REG_DWORD; - unsigned long buflen = sizeof(*throttle_delay); - bool throttle_ok = false; - ret = RegQueryValueEx(key, NSSM_REG_THROTTLE, 0, &type, (unsigned char *) throttle_delay, &buflen); - if (ret != ERROR_SUCCESS) { - if (ret != ERROR_FILE_NOT_FOUND) { - if (type != REG_DWORD) { - char milliseconds[16]; - _snprintf_s(milliseconds, sizeof(milliseconds), _TRUNCATE, "%lu", NSSM_RESET_THROTTLE_RESTART); - log_event(EVENTLOG_WARNING_TYPE, NSSM_EVENT_BOGUS_THROTTLE, service_name, NSSM_REG_THROTTLE, milliseconds, 0); - } - else log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_QUERYVALUE_FAILED, NSSM_REG_THROTTLE, error_string(GetLastError()), 0); - } - } - else throttle_ok = true; - - if (! throttle_ok) *throttle_delay = NSSM_RESET_THROTTLE_RESTART; + override_milliseconds(service_name, key, NSSM_REG_THROTTLE, throttle_delay, NSSM_RESET_THROTTLE_RESTART, NSSM_EVENT_BOGUS_THROTTLE); /* Try to get service stop flags. */ - type = REG_DWORD; + unsigned long type = REG_DWORD; unsigned long stop_method_skip; - buflen = sizeof(stop_method_skip); + unsigned long buflen = sizeof(stop_method_skip); bool stop_ok = false; ret = RegQueryValueEx(key, NSSM_REG_STOP_METHOD_SKIP, 0, &type, (unsigned char *) &stop_method_skip, &buflen); if (ret != ERROR_SUCCESS) { @@ -318,6 +322,11 @@ int get_parameters(char *service_name, char *exe, unsigned long exelen, char *fl *stop_method = ~0; if (stop_ok) *stop_method &= ~stop_method_skip; + /* Try to get kill delays - may fail. */ + override_milliseconds(service_name, key, NSSM_REG_KILL_CONSOLE_GRACE_PERIOD, kill_console_delay, NSSM_KILL_CONSOLE_GRACE_PERIOD, NSSM_EVENT_BOGUS_KILL_CONSOLE_GRACE_PERIOD); + override_milliseconds(service_name, key, NSSM_REG_KILL_WINDOW_GRACE_PERIOD, kill_window_delay, NSSM_KILL_WINDOW_GRACE_PERIOD, NSSM_EVENT_BOGUS_KILL_WINDOW_GRACE_PERIOD); + override_milliseconds(service_name, key, NSSM_REG_KILL_THREADS_GRACE_PERIOD, kill_threads_delay, NSSM_KILL_THREADS_GRACE_PERIOD, NSSM_EVENT_BOGUS_KILL_THREADS_GRACE_PERIOD); + /* Close registry */ RegCloseKey(key);