X-Git-Url: http://git.iain.cx/?a=blobdiff_plain;f=io.cpp;h=79848e94fc2a28bc17cdf2cdd2960f3469d42026;hb=2cd1c7c29ef4d2d3df3c5afd3ca6c788aede2bef;hp=1c0a9fffbe4a0ca2d1c4f7b4cac6d09e8601bc93;hpb=ce9eb5d4646a0e279eae2909a18fccb1197e15fb;p=nssm.git

diff --git a/io.cpp b/io.cpp
index 1c0a9ff..79848e9 100644
--- a/io.cpp
+++ b/io.cpp
@@ -1,12 +1,34 @@
 #include "nssm.h"
 
+#define COMPLAINED_READ (1 << 0)
+#define COMPLAINED_WRITE (1 << 1)
+#define COMPLAINED_ROTATE (1 << 2)
+
+static HANDLE create_logging_thread(logger_t *logger) {
+  HANDLE thread_handle = CreateThread(NULL, 0, log_and_rotate, (void *) logger, 0, logger->tid_ptr);
+  if (! thread_handle) log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_CREATETHREAD_FAILED, error_string(GetLastError()), 0);
+  return thread_handle;
+}
+
+static inline unsigned long guess_charsize(void *address, unsigned long bufsize) {
+  if (IsTextUnicode(address, bufsize, 0)) return (unsigned long) sizeof(wchar_t);
+  else return (unsigned long) sizeof(char);
+}
+
+static inline void write_bom(logger_t *logger, unsigned long *out) {
+  wchar_t bom = L'\ufeff';
+  if (! WriteFile(logger->write_handle, (void *) &bom, sizeof(bom), out, 0)) {
+    log_event(EVENTLOG_WARNING_TYPE, NSSM_EVENT_SOMEBODY_SET_UP_US_THE_BOM, logger->service_name, logger->path, error_string(GetLastError()), 0);
+  }
+}
+
 /* Get path, share mode, creation disposition and flags for a stream. */
-int get_createfile_parameters(HKEY key, char *prefix, char *path, unsigned long *sharing, unsigned long default_sharing, unsigned long *disposition, unsigned long default_disposition, unsigned long *flags, unsigned long default_flags) {
-  char value[NSSM_STDIO_LENGTH];
+int get_createfile_parameters(HKEY key, TCHAR *prefix, TCHAR *path, unsigned long *sharing, unsigned long default_sharing, unsigned long *disposition, unsigned long default_disposition, unsigned long *flags, unsigned long default_flags) {
+  TCHAR value[NSSM_STDIO_LENGTH];
 
   /* Path. */
-  if (_snprintf_s(value, sizeof(value), _TRUNCATE, "%s", prefix) < 0) {
-    log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, prefix, "get_createfile_parameters()", 0);
+  if (_sntprintf_s(value, _countof(value), _TRUNCATE, _T("%s"), prefix) < 0) {
+    log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, prefix, _T("get_createfile_parameters()"), 0);
     return 1;
   }
   switch (expand_parameter(key, value, path, MAX_PATH, true, false)) {
@@ -15,8 +37,8 @@ int get_createfile_parameters(HKEY key, char *prefix, char *path, unsigned long
   }
 
   /* ShareMode. */
-  if (_snprintf_s(value, sizeof(value), _TRUNCATE, "%s%s", prefix, NSSM_REG_STDIO_SHARING) < 0) {
-    log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, NSSM_REG_STDIO_SHARING, "get_createfile_parameters()", 0);
+  if (_sntprintf_s(value, _countof(value), _TRUNCATE, _T("%s%s"), prefix, NSSM_REG_STDIO_SHARING) < 0) {
+    log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, NSSM_REG_STDIO_SHARING, _T("get_createfile_parameters()"), 0);
     return 3;
   }
   switch (get_number(key, value, sharing, false)) {
@@ -26,8 +48,8 @@ int get_createfile_parameters(HKEY key, char *prefix, char *path, unsigned long
   }
 
   /* CreationDisposition. */
-  if (_snprintf_s(value, sizeof(value), _TRUNCATE, "%s%s", prefix, NSSM_REG_STDIO_DISPOSITION) < 0) {
-    log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, NSSM_REG_STDIO_DISPOSITION, "get_createfile_parameters()", 0);
+  if (_sntprintf_s(value, _countof(value), _TRUNCATE, _T("%s%s"), prefix, NSSM_REG_STDIO_DISPOSITION) < 0) {
+    log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, NSSM_REG_STDIO_DISPOSITION, _T("get_createfile_parameters()"), 0);
     return 5;
   }
   switch (get_number(key, value, disposition, false)) {
@@ -37,8 +59,8 @@ int get_createfile_parameters(HKEY key, char *prefix, char *path, unsigned long
   }
 
   /* Flags. */
-  if (_snprintf_s(value, sizeof(value), _TRUNCATE, "%s%s", prefix, NSSM_REG_STDIO_FLAGS) < 0) {
-    log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, NSSM_REG_STDIO_FLAGS, "get_createfile_parameters()", 0);
+  if (_sntprintf_s(value, _countof(value), _TRUNCATE, _T("%s%s"), prefix, NSSM_REG_STDIO_FLAGS) < 0) {
+    log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, NSSM_REG_STDIO_FLAGS, _T("get_createfile_parameters()"), 0);
     return 7;
   }
   switch (get_number(key, value, flags, false)) {
@@ -50,7 +72,30 @@ int get_createfile_parameters(HKEY key, char *prefix, char *path, unsigned long
   return 0;
 }
 
-HANDLE append_to_file(char *path, unsigned long sharing, SECURITY_ATTRIBUTES *attributes, unsigned long disposition, unsigned long flags) {
+int set_createfile_parameter(HKEY key, TCHAR *prefix, TCHAR *suffix, unsigned long number) {
+  TCHAR value[NSSM_STDIO_LENGTH];
+
+  if (_sntprintf_s(value, _countof(value), _TRUNCATE, _T("%s%s"), prefix, suffix) < 0) {
+    log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, suffix, _T("set_createfile_parameter()"), 0);
+    return 1;
+  }
+
+  return set_number(key, value, number);
+}
+
+int delete_createfile_parameter(HKEY key, TCHAR *prefix, TCHAR *suffix) {
+  TCHAR value[NSSM_STDIO_LENGTH];
+
+  if (_sntprintf_s(value, _countof(value), _TRUNCATE, _T("%s%s"), prefix, suffix) < 0) {
+    log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, suffix, _T("delete_createfile_parameter()"), 0);
+    return 1;
+  }
+
+  if (RegDeleteValue(key, value)) return 0;
+  return 1;
+}
+
+HANDLE append_to_file(TCHAR *path, unsigned long sharing, SECURITY_ATTRIBUTES *attributes, unsigned long disposition, unsigned long flags) {
   HANDLE ret;
 
   /* Try to append to the file first. */
@@ -62,7 +107,7 @@ HANDLE append_to_file(char *path, unsigned long sharing, SECURITY_ATTRIBUTES *at
 
   unsigned long error = GetLastError();
   if (error != ERROR_FILE_NOT_FOUND) {
-    log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_CREATEFILE_FAILED, path, error_string(error));
+    log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_CREATEFILE_FAILED, path, error_string(error), 0);
     return (HANDLE) 0;
   }
 
@@ -70,10 +115,91 @@ HANDLE append_to_file(char *path, unsigned long sharing, SECURITY_ATTRIBUTES *at
   return CreateFile(path, FILE_WRITE_DATA, sharing, attributes, disposition, flags, 0);
 }
 
-int get_output_handles(HKEY key, STARTUPINFO *si) {
-  char path[MAX_PATH];
-  char stdout_path[MAX_PATH];
-  unsigned long sharing, disposition, flags;
+static void rotated_filename(TCHAR *path, TCHAR *rotated, unsigned long rotated_len, SYSTEMTIME *st) {
+  if (! st) {
+    SYSTEMTIME now;
+    st = &now;
+    GetSystemTime(st);
+  }
+
+  TCHAR buffer[MAX_PATH];
+  memmove(buffer, path, sizeof(buffer));
+  TCHAR *ext = PathFindExtension(buffer);
+  TCHAR extension[MAX_PATH];
+  _sntprintf_s(extension, _countof(extension), _TRUNCATE, _T("-%04u%02u%02uT%02u%02u%02u.%03u%s"), st->wYear, st->wMonth, st->wDay, st->wHour, st->wMinute, st->wSecond, st->wMilliseconds, ext);
+  *ext = _T('\0');
+  _sntprintf_s(rotated, rotated_len, _TRUNCATE, _T("%s%s"), buffer, extension);
+}
+
+void rotate_file(TCHAR *service_name, TCHAR *path, unsigned long seconds, unsigned long low, unsigned long high) {
+  unsigned long error;
+
+  /* Now. */
+  SYSTEMTIME st;
+  GetSystemTime(&st);
+
+  BY_HANDLE_FILE_INFORMATION info;
+
+  /* Try to open the file to check if it exists and to get attributes. */
+  HANDLE file = CreateFile(path, 0, FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE, NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, 0);
+  if (file) {
+    /* Get file attributes. */
+    if (! GetFileInformationByHandle(file, &info)) {
+      /* Reuse current time for rotation timestamp. */
+      seconds = low = high = 0;
+      SystemTimeToFileTime(&st, &info.ftLastWriteTime);
+    }
+
+    CloseHandle(file);
+  }
+  else {
+    error = GetLastError();
+    if (error == ERROR_FILE_NOT_FOUND) return;
+    log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_ROTATE_FILE_FAILED, service_name, path, _T("CreateFile()"), path, error_string(error), 0);
+    /* Reuse current time for rotation timestamp. */
+    seconds = low = high = 0;
+    SystemTimeToFileTime(&st, &info.ftLastWriteTime);
+  }
+
+  /* Check file age. */
+  if (seconds) {
+    FILETIME ft;
+    SystemTimeToFileTime(&st, &ft);
+
+    ULARGE_INTEGER s;
+    s.LowPart = ft.dwLowDateTime;
+    s.HighPart = ft.dwHighDateTime;
+    s.QuadPart -= seconds * 10000000LL;
+    ft.dwLowDateTime = s.LowPart;
+    ft.dwHighDateTime = s.HighPart;
+    if (CompareFileTime(&info.ftLastWriteTime, &ft) > 0) return;
+  }
+
+  /* Check file size. */
+  if (low || high) {
+    if (info.nFileSizeHigh < high) return;
+    if (info.nFileSizeHigh == high && info.nFileSizeLow < low) return;
+  }
+
+  /* Get new filename. */
+  FileTimeToSystemTime(&info.ftLastWriteTime, &st);
+
+  TCHAR rotated[MAX_PATH];
+  rotated_filename(path, rotated, _countof(rotated), &st);
+
+  /* Rotate. */
+  if (MoveFile(path, rotated)) {
+    log_event(EVENTLOG_INFORMATION_TYPE, NSSM_EVENT_ROTATED, service_name, path, rotated, 0);
+    return;
+  }
+  error = GetLastError();
+
+  if (error == ERROR_FILE_NOT_FOUND) return;
+  log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_ROTATE_FILE_FAILED, service_name, path, _T("MoveFile()"), rotated, error_string(error), 0);
+  return;
+}
+
+int get_output_handles(nssm_service_t *service, HKEY key, STARTUPINFO *si) {
   bool set_flags = false;
 
   /* Standard security attributes allowing inheritance. */
@@ -82,50 +208,166 @@ int get_output_handles(HKEY key, STARTUPINFO *si) {
   attributes.bInheritHandle = true;
 
   /* stdin */
-  if (get_createfile_parameters(key, NSSM_REG_STDIN, path, &sharing, FILE_SHARE_WRITE, &disposition, OPEN_EXISTING, &flags, FILE_ATTRIBUTE_NORMAL)) return 1;
-  if (path[0]) {
-    si->hStdInput = CreateFile(path, FILE_READ_DATA, sharing, &attributes, disposition, flags, 0);
+  if (get_createfile_parameters(key, NSSM_REG_STDIN, service->stdin_path, &service->stdin_sharing, NSSM_STDIN_SHARING, &service->stdin_disposition, NSSM_STDIN_DISPOSITION, &service->stdin_flags, NSSM_STDIN_FLAGS)) {
+    service->stdin_sharing = service->stdin_disposition = service->stdin_flags = 0;
+    ZeroMemory(service->stdin_path, _countof(service->stdin_path) * sizeof(TCHAR));
+    return 1;
+  }
+  if (si && service->stdin_path[0]) {
+    si->hStdInput = CreateFile(service->stdin_path, FILE_READ_DATA, service->stdin_sharing, &attributes, service->stdin_disposition, service->stdin_flags, 0);
     if (! si->hStdInput) {
-      log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_CREATEFILE_FAILED, path, error_string(GetLastError()));
+      log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_CREATEFILE_FAILED, service->stdin_path, error_string(GetLastError()), 0);
       return 2;
     }
     set_flags = true;
   }
 
+  ULARGE_INTEGER size;
+  size.LowPart = service->rotate_bytes_low;
+  size.HighPart = service->rotate_bytes_high;
+
   /* stdout */
-  if (get_createfile_parameters(key, NSSM_REG_STDOUT, path, &sharing, FILE_SHARE_READ | FILE_SHARE_WRITE, &disposition, OPEN_ALWAYS, &flags, FILE_ATTRIBUTE_NORMAL)) return 3;
-  if (path[0]) {
-    /* Remember path for comparison with stderr. */
-    if (_snprintf_s(stdout_path, sizeof(stdout_path), _TRUNCATE, "%s", path) < 0) {
-      log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, "stdout_path", "get_output_handles", 0);
+  if (get_createfile_parameters(key, NSSM_REG_STDOUT, service->stdout_path, &service->stdout_sharing, NSSM_STDOUT_SHARING, &service->stdout_disposition, NSSM_STDOUT_DISPOSITION, &service->stdout_flags, NSSM_STDOUT_FLAGS)) {
+    service->stdout_sharing = service->stdout_disposition = service->stdout_flags = 0;
+    ZeroMemory(service->stdout_path, _countof(service->stdout_path) * sizeof(TCHAR));
+    return 3;
+  }
+  if (si && service->stdout_path[0]) {
+    if (service->rotate_files) rotate_file(service->name, service->stdout_path, service->rotate_seconds, service->rotate_bytes_low, service->rotate_bytes_high);
+    HANDLE stdout_handle = append_to_file(service->stdout_path, service->stdout_sharing, 0, service->stdout_disposition, service->stdout_flags);
+    if (! stdout_handle) {
+      log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_CREATEFILE_FAILED, service->stdout_path, error_string(GetLastError()), 0);
       return 4;
     }
 
-    si->hStdOutput = append_to_file(path, sharing, &attributes, disposition, flags);
-    if (! si->hStdOutput) return 5;
+    /* Try online rotation only if a size threshold is set. */
+    logger_t *stdout_logger = 0;
+    if (service->rotate_files && service->rotate_stdout_online) {
+      stdout_logger = (logger_t *) HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(logger_t));
+      if (stdout_logger) {
+        /* Pipe between application's stdout and our logging handle. */
+        if (CreatePipe(&service->stdout_pipe, &si->hStdOutput, &attributes, 0)) {
+          stdout_logger->service_name = service->name;
+          stdout_logger->path = service->stdout_path;
+          stdout_logger->sharing = service->stdout_sharing;
+          stdout_logger->disposition = service->stdout_disposition;
+          stdout_logger->flags = service->stdout_flags;
+          stdout_logger->read_handle = service->stdout_pipe;
+          stdout_logger->write_handle = stdout_handle;
+          stdout_logger->size = (__int64) size.QuadPart;
+          stdout_logger->tid_ptr = &service->stdout_tid;
+          stdout_logger->rotate_online = &service->rotate_stdout_online;
+
+          /* Logging thread. */
+          service->stdout_thread = create_logging_thread(stdout_logger);
+          if (! service->stdout_thread) {
+            log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_CREATEPIPE_FAILED, service->name, service->stdout_path, error_string(GetLastError()));
+            CloseHandle(service->stdout_pipe);
+            CloseHandle(si->hStdOutput);
+            service->stdout_tid = 0;
+          }
+        }
+        else service->stdout_tid = 0;
+      }
+      else {
+        log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, _T("stdout_logger"), _T("get_output_handles()"), 0);
+        service->stdout_tid = 0;
+      }
+
+      /* Fall through to try direct I/O. */
+      if (! service->stdout_tid) log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_CREATEPIPE_FAILED, service->name, service->stdout_path, error_string(GetLastError()));
+    }
+
+    if (! service->stdout_tid) {
+      if (stdout_logger) HeapFree(GetProcessHeap(), 0, stdout_logger);
+      if (! DuplicateHandle(GetCurrentProcess(), stdout_handle, GetCurrentProcess(), &si->hStdOutput, 0, true, DUPLICATE_CLOSE_SOURCE | DUPLICATE_SAME_ACCESS)) {
+        log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_DUPLICATEHANDLE_FAILED, NSSM_REG_STDOUT, error_string(GetLastError()), 0);
+        return 4;
+      }
+      service->rotate_stdout_online = NSSM_ROTATE_OFFLINE;
+    }
+
     set_flags = true;
   }
-  else ZeroMemory(stdout_path, sizeof(stdout_path));
 
   /* stderr */
-  if (get_createfile_parameters(key, NSSM_REG_STDERR, path, &sharing, FILE_SHARE_READ | FILE_SHARE_WRITE, &disposition, OPEN_ALWAYS, &flags, FILE_ATTRIBUTE_NORMAL)) return 6;
-  if (path[0]) {
-    /* Same as stdin? */
-    if (str_equiv(path, stdout_path)) {
-      /* Two handles to the same file will create a race. */
-      if (! DuplicateHandle(GetCurrentProcess(), si->hStdOutput, GetCurrentProcess(), &si->hStdError, 0, true, DUPLICATE_SAME_ACCESS)) {
-        log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_DUPLICATEHANDLE_FAILED, NSSM_REG_STDOUT, error_string(GetLastError()));
-        return 7;
+  if (get_createfile_parameters(key, NSSM_REG_STDERR, service->stderr_path, &service->stderr_sharing, NSSM_STDERR_SHARING, &service->stderr_disposition, NSSM_STDERR_DISPOSITION, &service->stderr_flags, NSSM_STDERR_FLAGS)) {
+    service->stderr_sharing = service->stderr_disposition = service->stderr_flags = 0;
+    ZeroMemory(service->stderr_path, _countof(service->stderr_path) * sizeof(TCHAR));
+    return 5;
+  }
+  if (service->stderr_path[0]) {
+    /* Same as stdout? */
+    if (str_equiv(service->stderr_path, service->stdout_path)) {
+      service->stderr_sharing = service->stdout_sharing;
+      service->stderr_disposition = service->stdout_disposition;
+      service->stderr_flags = service->stdout_flags;
+      service->rotate_stderr_online = false;
+
+      if (si) {
+        /* Two handles to the same file will create a race. */
+        if (! DuplicateHandle(GetCurrentProcess(), si->hStdOutput, GetCurrentProcess(), &si->hStdError, 0, true, DUPLICATE_SAME_ACCESS)) {
+          log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_DUPLICATEHANDLE_FAILED, NSSM_REG_STDOUT, error_string(GetLastError()), 0);
+          return 6;
+        }
       }
     }
-    else {
-      si->hStdError = append_to_file(path, sharing, &attributes, disposition, flags);
-      if (! si->hStdError) {
-        log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_CREATEFILE_FAILED, path, error_string(GetLastError()));
-        return 8;
+    else if (si) {
+      if (service->rotate_files) rotate_file(service->name, service->stderr_path, service->rotate_seconds, service->rotate_bytes_low, service->rotate_bytes_high);
+      HANDLE stderr_handle = append_to_file(service->stderr_path, service->stderr_sharing, 0, service->stderr_disposition, service->stderr_flags);
+      if (! stderr_handle) {
+        log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_CREATEFILE_FAILED, service->stderr_path, error_string(GetLastError()), 0);
+        return 7;
+      }
+
+      /* Try online rotation only if a size threshold is set. */
+      logger_t *stderr_logger = 0;
+      if (service->rotate_files && service->rotate_stderr_online) {
+        stderr_logger = (logger_t *) HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(logger_t));
+        if (stderr_logger) {
+          /* Pipe between application's stderr and our logging handle. */
+          if (CreatePipe(&service->stderr_pipe, &si->hStdError, &attributes, 0)) {
+            stderr_logger->service_name = service->name;
+            stderr_logger->path = service->stderr_path;
+            stderr_logger->sharing = service->stderr_sharing;
+            stderr_logger->disposition = service->stderr_disposition;
+            stderr_logger->flags = service->stderr_flags;
+            stderr_logger->read_handle = service->stderr_pipe;
+            stderr_logger->write_handle = stderr_handle;
+            stderr_logger->size = (__int64) size.QuadPart;
+            stderr_logger->tid_ptr = &service->stderr_tid;
+            stderr_logger->rotate_online = &service->rotate_stderr_online;
+
+            /* Logging thread. */
+            service->stderr_thread = create_logging_thread(stderr_logger);
+            if (! service->stderr_thread) {
+              log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_CREATEPIPE_FAILED, service->name, service->stderr_path, error_string(GetLastError()));
+              CloseHandle(service->stderr_pipe);
+              CloseHandle(si->hStdError);
+              service->stderr_tid = 0;
+            }
+          }
+          else service->stderr_tid = 0;
+        }
+        else {
+          log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, _T("stderr_logger"), _T("get_output_handles()"), 0);
+          service->stderr_tid = 0;
+        }
+
+        /* Fall through to try direct I/O. */
+        if (! service->stderr_tid) log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_CREATEPIPE_FAILED, service->name, service->stderr_path, error_string(GetLastError()));
+      }
+
+      if (! service->stderr_tid) {
+        if (stderr_logger) HeapFree(GetProcessHeap(), 0, stderr_logger);
+        if (! DuplicateHandle(GetCurrentProcess(), stderr_handle, GetCurrentProcess(), &si->hStdError, 0, true, DUPLICATE_CLOSE_SOURCE | DUPLICATE_SAME_ACCESS)) {
+          log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_DUPLICATEHANDLE_FAILED, NSSM_REG_STDERR, error_string(GetLastError()), 0);
+          return 7;
+        }
+        service->rotate_stderr_online = NSSM_ROTATE_OFFLINE;
       }
-      SetEndOfFile(si->hStdError);
     }
+
     set_flags = true;
   }
 
@@ -135,13 +377,217 @@ int get_output_handles(HKEY key, STARTUPINFO *si) {
     We need to set the startup_info flags to make the new handles
     inheritable by the new process.
   */
-  si->dwFlags |= STARTF_USESTDHANDLES;
+  if (si) si->dwFlags |= STARTF_USESTDHANDLES;
 
   return 0;
 }
 
-void close_output_handles(STARTUPINFO *si) {
+void close_output_handles(STARTUPINFO *si, bool close_stdout, bool close_stderr) {
   if (si->hStdInput) CloseHandle(si->hStdInput);
-  if (si->hStdOutput) CloseHandle(si->hStdOutput);
-  if (si->hStdError) CloseHandle(si->hStdError);
+  if (si->hStdOutput && close_stdout) CloseHandle(si->hStdOutput);
+  if (si->hStdError && close_stderr) CloseHandle(si->hStdError);
+}
+
+void close_output_handles(STARTUPINFO *si) {
+  return close_output_handles(si, true, true);
+}
+
+/*
+  Try multiple times to read from a file.
+  Returns:  0 on success.
+            1 on non-fatal error.
+           -1 on fatal error.
+*/
+static int try_read(logger_t *logger, void *address, unsigned long bufsize, unsigned long *in, int *complained) {
+  int ret = 1;
+  unsigned long error;
+  for (int tries = 0; tries < 5; tries++) {
+    if (ReadFile(logger->read_handle, address, bufsize, in, 0)) return 0;
+
+    error = GetLastError();
+    switch (error) {
+      /* Other end closed the pipe. */
+      case ERROR_BROKEN_PIPE:
+        ret = -1;
+        goto complain_read;
+
+      /* Couldn't lock the buffer. */
+      case ERROR_NOT_ENOUGH_QUOTA:
+        Sleep(2000 + tries * 3000);
+        ret = 1;
+        continue;
+
+      /* Write was cancelled by the other end. */
+      case ERROR_OPERATION_ABORTED:
+        ret = 1;
+        goto complain_read;
+
+      default:
+        ret = -1;
+    }
+  }
+
+complain_read:
+  if (! (*complained & COMPLAINED_READ)) log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_READFILE_FAILED, logger->service_name, logger->path, error_string(error), 0);
+  *complained |= COMPLAINED_READ;
+  return ret;
+}
+
+/*
+  Try multiple times to write to a file.
+  Returns:  0 on success.
+            1 on non-fatal error.
+           -1 on fatal error.
+*/
+static int try_write(logger_t *logger, void *address, unsigned long bufsize, unsigned long *out, int *complained) {
+  int ret = 1;
+  unsigned long error;
+  for (int tries = 0; tries < 5; tries++) {
+    if (WriteFile(logger->write_handle, address, bufsize, out, 0)) return 0;
+
+    error = GetLastError();
+    if (error == ERROR_IO_PENDING) {
+      /* Operation was successful pending flush to disk. */
+      return 0;
+    }
+
+    switch (error) {
+      /* Other end closed the pipe. */
+      case ERROR_BROKEN_PIPE:
+        ret = -1;
+        goto complain_write;
+
+      /* Couldn't lock the buffer. */
+      case ERROR_NOT_ENOUGH_QUOTA:
+      /* Out of disk space. */
+      case ERROR_DISK_FULL:
+        Sleep(2000 + tries * 3000);
+        ret = 1;
+        continue;
+
+      default:
+        /* We'll lose this line but try to read and write subsequent ones. */
+        ret = 1;
+    }
+  }
+
+complain_write:
+  if (! (*complained & COMPLAINED_WRITE)) log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_WRITEFILE_FAILED, logger->service_name, logger->path, error_string(error), 0);
+  *complained |= COMPLAINED_WRITE;
+  return ret;
+}
+
+/* Wrapper to be called in a new thread for logging. */
+unsigned long WINAPI log_and_rotate(void *arg) {
+  logger_t *logger = (logger_t *) arg;
+  if (! logger) return 1;
+
+  __int64 size;
+  BY_HANDLE_FILE_INFORMATION info;
+
+  /* Find initial file size. */
+  if (! GetFileInformationByHandle(logger->write_handle, &info)) logger->size = 0LL;
+  else {
+    ULARGE_INTEGER l;
+    l.HighPart = info.nFileSizeHigh;
+    l.LowPart = info.nFileSizeLow;
+    size = l.QuadPart;
+  }
+
+  char buffer[1024];
+  void *address;
+  unsigned long in, out;
+  unsigned long charsize = 0;
+  unsigned long error;
+  int ret;
+  int complained = 0;
+
+  while (true) {
+    /* Read data from the pipe. */
+    address = &buffer;
+    ret = try_read(logger, address, sizeof(buffer), &in, &complained);
+    if (ret < 0) {
+      HeapFree(GetProcessHeap(), 0, logger);
+      return 2;
+    }
+    else if (ret) continue;
+
+    if (*logger->rotate_online == NSSM_ROTATE_ONLINE_ASAP || (logger->size && size + (__int64) in >= logger->size)) {
+      /* Look for newline. */
+      unsigned long i;
+      for (i = 0; i < in; i++) {
+        if (buffer[i] == '\n') {
+          if (! charsize) charsize = guess_charsize(address, in);
+          i += charsize;
+
+          /* Write up to the newline. */
+          ret = try_write(logger, address, i, &out, &complained);
+          if (ret < 0) {
+            HeapFree(GetProcessHeap(), 0, logger);
+            return 3;
+          }
+          size += (__int64) out;
+
+          /* Rotate. */
+          *logger->rotate_online = NSSM_ROTATE_ONLINE;
+          TCHAR rotated[MAX_PATH];
+          rotated_filename(logger->path, rotated, _countof(rotated), 0);
+
+          /*
+            Ideally we'd try the rename first then close the handle but
+            MoveFile() will fail if the handle is still open so we must
+            risk losing everything.
+          */
+          CloseHandle(logger->write_handle);
+          if (MoveFile(logger->path, rotated)) {
+            log_event(EVENTLOG_INFORMATION_TYPE, NSSM_EVENT_ROTATED, logger->service_name, logger->path, rotated, 0);
+            size = 0LL;
+          }
+          else {
+            error = GetLastError();
+            if (error != ERROR_FILE_NOT_FOUND) {
+              if (! (complained & COMPLAINED_ROTATE)) log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_ROTATE_FILE_FAILED, logger->service_name, logger->path, _T("MoveFile()"), rotated, error_string(error), 0);
+              complained |= COMPLAINED_ROTATE;
+              /* We can at least try to re-open the existing file. */
+              logger->disposition = OPEN_ALWAYS;
+            }
+          }
+
+          /* Reopen. */
+          logger->write_handle = append_to_file(logger->path, logger->sharing, 0, logger->disposition, logger->flags);
+          if (! logger->write_handle) {
+            error = GetLastError();
+            log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_CREATEFILE_FAILED, logger->path, error_string(error), 0);
+            /* Oh dear.  Now we can't log anything further. */
+            HeapFree(GetProcessHeap(), 0, logger);
+            return 4;
+          }
+
+          /* Resume writing after the newline. */
+          address = (void *) ((char *) address + i);
+          in -= i;
+        }
+      }
+    }
+
+    if (! size) {
+      /* Write a BOM to the new file. */
+      if (! charsize) charsize = guess_charsize(address, in);
+      if (charsize == sizeof(wchar_t)) write_bom(logger, &out);
+      size += (__int64) out;
+    }
+
+    /* Write the data, if any. */
+    if (! in) continue;
+
+    ret = try_write(logger, address, in, &out, &complained);
+    size += (__int64) out;
+    if (ret < 0) {
+      HeapFree(GetProcessHeap(), 0, logger);
+      return 3;
+    }
+  }
+
+  HeapFree(GetProcessHeap(), 0, logger);
+  return 0;
 }