X-Git-Url: http://git.iain.cx/?a=blobdiff_plain;f=.profile.d%2FPATH.bashrc;h=3113f75a54ddec55d0fff56c08de953c377c5ee8;hb=832c2a2fe8a769c0fe7d8d441148fbf82e762a4c;hp=66d61b3b304716b2bb881bb83ea1e7053e03886c;hpb=7e973fb6a4ec8da564b4621658e2c4d583560d33;p=profile.git

diff --git a/.profile.d/PATH.bashrc b/.profile.d/PATH.bashrc
index 66d61b3..3113f75 100644
--- a/.profile.d/PATH.bashrc
+++ b/.profile.d/PATH.bashrc
@@ -1,11 +1,9 @@
-# $Id$
-#
 # Path information is stored on separate lines in XXXdirs.
 # We extract each directory exists and add it to the appropriate PATH.
 #
 
 # Location of the XXXdirs files.
-DIR=$HOME/.profile.d
+DIR="$HOME/.profile.d"
 
 # Set one path to be the same as another.
 function copypath() {
@@ -14,7 +12,7 @@ function copypath() {
 
   # Sanitise and export.
   path="$(eval echo \$$oldpath)"
-  [ -z "$path" ] || eval export $newpath="$path"
+  [ -z "$path" ] || eval "export $newpath='$path'"
 
   unset path newpath oldpath
 }
@@ -27,21 +25,30 @@ function makepath() {
   # Check the file exists.
   [ -e "$DIR/$dirs" ] || return
 
+  # Set IFS to newline only so that we can read $(embedded shell commands).
+  JGD=$IFS
+  IFS='
+'
   # Read them.
   path=
-  for dir in $(cat "$DIR/$dirs"); do
+  while read dir; do
+    dir=$(eval echo "$dir")
     [ -d "$dir" ] || continue
 
     path="$path:$dir"
-  done
+  done < "$DIR/$dirs"
   unset dir
 
+  # Restore IFS.
+  IFS=$JGD
+  unset JGD
+
   # Sanitise path.
   path=${path#:}
   [ -z "$path" ] && return
 
   # Export.
-  eval export $newpath="$path"
+  eval "export $newpath='$path'"
 
   unset path newpath dirs
 }