return qsc;\r
}\r
\r
+/* WILL NOT allocate a new string if the identifier is already present. */\r
+int prepend_service_group_identifier(TCHAR *group, TCHAR **canon) {\r
+ if (! group || ! group[0] || group[0] == SC_GROUP_IDENTIFIER) {\r
+ *canon = group;\r
+ return 0;\r
+ }\r
+\r
+ size_t len = _tcslen(group) + 1;\r
+ *canon = (TCHAR *) HeapAlloc(GetProcessHeap(), 0, (len + 1) * sizeof(TCHAR));\r
+ if (! *canon) {\r
+ print_message(stderr, NSSM_MESSAGE_OUT_OF_MEMORY, _T("canon"), _T("prepend_service_group_identifier()"));\r
+ return 1;\r
+ }\r
+\r
+ TCHAR *s = *canon;\r
+ *s++ = SC_GROUP_IDENTIFIER;\r
+ memmove(s, group, len * sizeof(TCHAR));\r
+ (*canon)[len] = _T('\0');\r
+\r
+ return 0;\r
+}\r
+\r
+int append_to_dependencies(TCHAR *dependencies, unsigned long dependencieslen, TCHAR *string, TCHAR **newdependencies, unsigned long *newlen, int type) {\r
+ *newlen = 0;\r
+\r
+ TCHAR *canon = 0;\r
+ if (type == DEPENDENCY_GROUPS) {\r
+ if (prepend_service_group_identifier(string, &canon)) return 1;\r
+ }\r
+ else canon = string;\r
+ int ret = append_to_double_null(dependencies, dependencieslen, newdependencies, newlen, canon, 0, false);\r
+ if (canon && canon != string) HeapFree(GetProcessHeap(), 0, canon);\r
+\r
+ return ret;\r
+}\r
+\r
+int remove_from_dependencies(TCHAR *dependencies, unsigned long dependencieslen, TCHAR *string, TCHAR **newdependencies, unsigned long *newlen, int type) {\r
+ *newlen = 0;\r
+\r
+ TCHAR *canon = 0;\r
+ if (type == DEPENDENCY_GROUPS) {\r
+ if (prepend_service_group_identifier(string, &canon)) return 1;\r
+ }\r
+ else canon = string;\r
+ int ret = remove_from_double_null(dependencies, dependencieslen, newdependencies, newlen, canon, 0, false);\r
+ if (canon && canon != string) HeapFree(GetProcessHeap(), 0, canon);\r
+\r
+ return ret;\r
+}\r
+\r
int set_service_dependencies(const TCHAR *service_name, SC_HANDLE service_handle, TCHAR *buffer) {\r
TCHAR *dependencies = _T("");\r
unsigned long num_dependencies = 0;\r
QUERY_SERVICE_CONFIG *qsc = query_service_config(service_name, service_handle);\r
if (! qsc) return 3;\r
\r
- if (! qsc->lpDependencies) return 0;\r
- if (! qsc->lpDependencies[0]) return 0;\r
+ if (! qsc->lpDependencies || ! qsc->lpDependencies[0]) {\r
+ HeapFree(GetProcessHeap(), 0, qsc);\r
+ return 0;\r
+ }\r
\r
/* lpDependencies is doubly NULL terminated. */\r
while (qsc->lpDependencies[*bufsize]) {\r
if (! *buffer) {\r
*bufsize = 0;\r
print_message(stderr, NSSM_MESSAGE_OUT_OF_MEMORY, _T("lpDependencies"), _T("get_service_dependencies()"));\r
+ HeapFree(GetProcessHeap(), 0, qsc);\r
return 4;\r
}\r
\r
\r
HeapFree(GetProcessHeap(), 0, qsc);\r
\r
+ if (! *buffer[0]) {\r
+ HeapFree(GetProcessHeap(), 0, *buffer);\r
+ *buffer = 0;\r
+ *bufsize = 0;\r
+ }\r
+\r
return 0;\r
}\r
\r
}\r
\r
if (! service->native) {\r
- key = open_registry(service->name, KEY_WRITE);\r
+ key = open_registry(service->name, KEY_READ | KEY_WRITE);\r
if (! key) {\r
if (value.string) HeapFree(GetProcessHeap(), 0, value.string);\r
return 4;\r
service->status.dwControlsAccepted = SERVICE_ACCEPT_POWEREVENT | SERVICE_ACCEPT_SHUTDOWN | SERVICE_ACCEPT_STOP;\r
SetServiceStatus(service->status_handle, &service->status);\r
\r
- /* Pre-start hook. */\r
unsigned long control = NSSM_SERVICE_CONTROL_START;\r
- if (nssm_hook(&hook_threads, service, NSSM_HOOK_EVENT_START, NSSM_HOOK_ACTION_PRE, &control, NSSM_SERVICE_STATUS_DEADLINE, false) == NSSM_HOOK_STATUS_ABORT) {\r
- TCHAR code[16];\r
- _sntprintf_s(code, _countof(code), _TRUNCATE, _T("%lu"), NSSM_HOOK_STATUS_ABORT);\r
- log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_PRESTART_HOOK_ABORT, NSSM_HOOK_EVENT_START, NSSM_HOOK_ACTION_PRE, service->name, code, 0);\r
- unset_service_environment(service);\r
- return stop_service(service, 5, true, true);\r
- }\r
\r
/* Did another thread receive a stop control? */\r
if (service->allow_restart) {\r
return stop_service(service, 4, true, true);\r
}\r
\r
+ /* Pre-start hook. May need I/O to have been redirected already. */\r
+ if (nssm_hook(&hook_threads, service, NSSM_HOOK_EVENT_START, NSSM_HOOK_ACTION_PRE, &control, NSSM_SERVICE_STATUS_DEADLINE, false) == NSSM_HOOK_STATUS_ABORT) {\r
+ TCHAR code[16];\r
+ _sntprintf_s(code, _countof(code), _TRUNCATE, _T("%lu"), NSSM_HOOK_STATUS_ABORT);\r
+ log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_PRESTART_HOOK_ABORT, NSSM_HOOK_EVENT_START, NSSM_HOOK_ACTION_PRE, service->name, code, 0);\r
+ unset_service_environment(service);\r
+ return stop_service(service, 5, true, true);\r
+ }\r
+\r
/* The pre-start hook will have cleaned the environment. */\r
set_service_environment(service);\r
\r