HKEY key;\r
\r
char registry[KEY_LENGTH];\r
- if (_snprintf(registry, sizeof(registry), "SYSTEM\\CurrentControlSet\\Services\\EventLog\\Application\\%s", NSSM) < 0) {\r
+ if (_snprintf_s(registry, sizeof(registry), _TRUNCATE, "SYSTEM\\CurrentControlSet\\Services\\EventLog\\Application\\%s", NSSM) < 0) {\r
log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, "eventlog registry", "create_messages()", 0);\r
return 1;\r
}\r
\r
if (RegCreateKeyEx(HKEY_LOCAL_MACHINE, registry, 0, 0, REG_OPTION_NON_VOLATILE, KEY_WRITE, 0, &key, 0) != ERROR_SUCCESS) {\r
- log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OPENKEY_FAILED, registry, GetLastError(), 0);\r
+ log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OPENKEY_FAILED, registry, error_string(GetLastError()), 0);\r
return 2;\r
}\r
\r
GetModuleFileName(0, path, MAX_PATH);\r
\r
/* Try to register the module but don't worry so much on failure */\r
- RegSetValueEx(key, "EventMessageFile", 0, REG_SZ, (const unsigned char *) path, strlen(path) + 1);\r
+ RegSetValueEx(key, "EventMessageFile", 0, REG_SZ, (const unsigned char *) path, (unsigned long) strlen(path) + 1);\r
unsigned long types = EVENTLOG_INFORMATION_TYPE | EVENTLOG_WARNING_TYPE | EVENTLOG_ERROR_TYPE;\r
RegSetValueEx(key, "TypesSupported", 0, REG_DWORD, /*XXX*/(PBYTE) &types, sizeof(types));\r
\r
int create_parameters(char *service_name, char *exe, char *flags, char *dir) {\r
/* Get registry */\r
char registry[KEY_LENGTH];\r
- if (_snprintf(registry, sizeof(registry), NSSM_REGISTRY, service_name) < 0) {\r
+ if (_snprintf_s(registry, sizeof(registry), _TRUNCATE, NSSM_REGISTRY, service_name) < 0) {\r
log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, "NSSM_REGISTRY", "create_parameters()", 0);\r
return 1;\r
}\r
/* Try to open the registry */\r
HKEY key;\r
if (RegCreateKeyEx(HKEY_LOCAL_MACHINE, registry, 0, 0, REG_OPTION_NON_VOLATILE, KEY_WRITE, 0, &key, 0) != ERROR_SUCCESS) {\r
- log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OPENKEY_FAILED, registry, GetLastError(), 0);\r
+ log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OPENKEY_FAILED, registry, error_string(GetLastError()), 0);\r
return 2;\r
}\r
\r
/* Try to create the parameters */\r
- if (RegSetValueEx(key, NSSM_REG_EXE, 0, REG_EXPAND_SZ, (const unsigned char *) exe, strlen(exe) + 1) != ERROR_SUCCESS) {\r
- log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_SETVALUE_FAILED, NSSM_REG_EXE, GetLastError(), 0);\r
+ if (RegSetValueEx(key, NSSM_REG_EXE, 0, REG_EXPAND_SZ, (const unsigned char *) exe, (unsigned long) strlen(exe) + 1) != ERROR_SUCCESS) {\r
+ log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_SETVALUE_FAILED, NSSM_REG_EXE, error_string(GetLastError()), 0);\r
RegDeleteKey(HKEY_LOCAL_MACHINE, NSSM_REGISTRY);\r
RegCloseKey(key);\r
return 3;\r
}\r
- if (RegSetValueEx(key, NSSM_REG_FLAGS, 0, REG_EXPAND_SZ, (const unsigned char *) flags, strlen(flags) + 1) != ERROR_SUCCESS) {\r
- log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_SETVALUE_FAILED, NSSM_REG_FLAGS, GetLastError(), 0);\r
+ if (RegSetValueEx(key, NSSM_REG_FLAGS, 0, REG_EXPAND_SZ, (const unsigned char *) flags, (unsigned long) strlen(flags) + 1) != ERROR_SUCCESS) {\r
+ log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_SETVALUE_FAILED, NSSM_REG_FLAGS, error_string(GetLastError()), 0);\r
RegDeleteKey(HKEY_LOCAL_MACHINE, NSSM_REGISTRY);\r
RegCloseKey(key);\r
return 4;\r
}\r
- if (RegSetValueEx(key, NSSM_REG_DIR, 0, REG_EXPAND_SZ, (const unsigned char *) dir, strlen(dir) + 1) != ERROR_SUCCESS) {\r
- log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_SETVALUE_FAILED, NSSM_REG_DIR, GetLastError(), 0);\r
+ if (RegSetValueEx(key, NSSM_REG_DIR, 0, REG_EXPAND_SZ, (const unsigned char *) dir, (unsigned long) strlen(dir) + 1) != ERROR_SUCCESS) {\r
+ log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_SETVALUE_FAILED, NSSM_REG_DIR, error_string(GetLastError()), 0);\r
RegDeleteKey(HKEY_LOCAL_MACHINE, NSSM_REGISTRY);\r
RegCloseKey(key);\r
return 5;\r
int create_exit_action(char *service_name, const char *action_string) {\r
/* Get registry */\r
char registry[KEY_LENGTH];\r
- if (_snprintf(registry, sizeof(registry), NSSM_REGISTRY "\\%s", service_name, NSSM_REG_EXIT) < 0) {\r
+ if (_snprintf_s(registry, sizeof(registry), _TRUNCATE, NSSM_REGISTRY "\\%s", service_name, NSSM_REG_EXIT) < 0) {\r
log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, "NSSM_REG_EXIT", "create_exit_action()", 0);\r
return 1;\r
}\r
HKEY key;\r
unsigned long disposition;\r
if (RegCreateKeyEx(HKEY_LOCAL_MACHINE, registry, 0, 0, REG_OPTION_NON_VOLATILE, KEY_WRITE, 0, &key, &disposition) != ERROR_SUCCESS) {\r
- log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OPENKEY_FAILED, registry, GetLastError(), 0);\r
+ log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OPENKEY_FAILED, registry, error_string(GetLastError()), 0);\r
return 2;\r
}\r
\r
}\r
\r
/* Create the default value */\r
- if (RegSetValueEx(key, 0, 0, REG_SZ, (const unsigned char *) action_string, strlen(action_string) + 1) != ERROR_SUCCESS) {\r
- log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_SETVALUE_FAILED, NSSM_REG_EXIT, GetLastError(), 0);\r
+ if (RegSetValueEx(key, 0, 0, REG_SZ, (const unsigned char *) action_string, (unsigned long) strlen(action_string) + 1) != ERROR_SUCCESS) {\r
+ log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_SETVALUE_FAILED, NSSM_REG_EXIT, error_string(GetLastError()), 0);\r
RegCloseKey(key);\r
return 3;\r
}\r
return 0;\r
}\r
\r
-int expand_parameter(HKEY key, char *value, char *data, unsigned long datalen) {\r
+int set_environment(char *service_name, HKEY key, char **env) {\r
+ unsigned long type = REG_MULTI_SZ;\r
+ unsigned long envlen = 0;\r
+\r
+ /* Dummy test to find buffer size */\r
+ unsigned long ret = RegQueryValueEx(key, NSSM_REG_ENV, 0, &type, NULL, &envlen);\r
+ if (ret != ERROR_SUCCESS) {\r
+ /* The service probably doesn't have any environment configured */\r
+ if (ret == ERROR_FILE_NOT_FOUND) return 0;\r
+ log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_QUERYVALUE_FAILED, NSSM_REG_ENV, error_string(GetLastError()), 0);\r
+ return 1;\r
+ }\r
+\r
+ if (type != REG_MULTI_SZ) {\r
+ log_event(EVENTLOG_WARNING_TYPE, NSSM_EVENT_INVALID_ENVIRONMENT_STRING_TYPE, NSSM_REG_ENV, service_name, 0);\r
+ return 2;\r
+ }\r
+\r
+ /* Probably not possible */\r
+ if (! envlen) return 0;\r
+\r
+ *env = (char *) HeapAlloc(GetProcessHeap(), 0, envlen);\r
+ if (! *env) {\r
+ log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, "environment registry", "set_environment()", 0);\r
+ return 3;\r
+ }\r
+\r
+ /* Actually get the strings */\r
+ ret = RegQueryValueEx(key, NSSM_REG_ENV, 0, &type, (unsigned char *) *env, &envlen);\r
+ if (ret != ERROR_SUCCESS) {\r
+ HeapFree(GetProcessHeap(), 0, *env);\r
+ *env = 0;\r
+ log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_QUERYVALUE_FAILED, NSSM_REG_ENV, error_string(GetLastError()), 0);\r
+ return 4;\r
+ }\r
+\r
+ return 0;\r
+}\r
+\r
+int expand_parameter(HKEY key, char *value, char *data, unsigned long datalen, bool sanitise, bool must_exist) {\r
unsigned char *buffer = (unsigned char *) HeapAlloc(GetProcessHeap(), 0, datalen);\r
if (! buffer) {\r
log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, value, "expand_parameter()", 0);\r
return 1;\r
}\r
\r
+ ZeroMemory(data, datalen);\r
+\r
unsigned long type = REG_EXPAND_SZ;\r
unsigned long buflen = datalen;\r
\r
unsigned long ret = RegQueryValueEx(key, value, 0, &type, buffer, &buflen);\r
if (ret != ERROR_SUCCESS) {\r
- if (ret != ERROR_FILE_NOT_FOUND) log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_QUERYVALUE_FAILED, value, GetLastError(), 0);\r
+ unsigned long error = GetLastError();\r
HeapFree(GetProcessHeap(), 0, buffer);\r
+\r
+ if (ret == ERROR_FILE_NOT_FOUND) {\r
+ if (! must_exist) return 0;\r
+ }\r
+\r
+ log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_QUERYVALUE_FAILED, value, error_string(error), 0);\r
return 2;\r
}\r
\r
- ZeroMemory(data, datalen);\r
+ /* Paths aren't allowed to contain quotes. */\r
+ if (sanitise) PathUnquoteSpaces((LPSTR) buffer);\r
\r
/* Technically we shouldn't expand environment strings from REG_SZ values */\r
if (type != REG_EXPAND_SZ) {\r
\r
ret = ExpandEnvironmentStrings((char *) buffer, data, datalen);\r
if (! ret || ret > datalen) {\r
- log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_EXPANDENVIRONMENTSTRINGS_FAILED, value, buffer, GetLastError(), 0);\r
+ log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_EXPANDENVIRONMENTSTRINGS_FAILED, buffer, error_string(GetLastError()), 0);\r
HeapFree(GetProcessHeap(), 0, buffer);\r
return 3;\r
}\r
return 0;\r
}\r
\r
-int get_parameters(char *service_name, char *exe, int exelen, char *flags, int flagslen, char *dir, int dirlen) {\r
+int expand_parameter(HKEY key, char *value, char *data, unsigned long datalen, bool sanitise) {\r
+ return expand_parameter(key, value, data, datalen, sanitise, true);\r
+}\r
+\r
+/*\r
+ Query an unsigned long from the registry.\r
+ Returns: 1 if a number was retrieved.\r
+ 0 if none was found and must_exist is false.\r
+ -1 if none was found and must_exist is true.\r
+ -2 otherwise.\r
+*/\r
+int get_number(HKEY key, char *value, unsigned long *number, bool must_exist) {\r
+ unsigned long type = REG_DWORD;\r
+ unsigned long number_len = sizeof(unsigned long);\r
+\r
+ int ret = RegQueryValueEx(key, value, 0, &type, (unsigned char *) number, &number_len);\r
+ if (ret == ERROR_SUCCESS) return 1;\r
+\r
+ if (ret == ERROR_FILE_NOT_FOUND) {\r
+ if (! must_exist) return 0;\r
+ }\r
+\r
+ log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_QUERYVALUE_FAILED, value, error_string(GetLastError()), 0);\r
+ if (ret == ERROR_FILE_NOT_FOUND) return -1;\r
+\r
+ return -2;\r
+}\r
+\r
+int get_number(HKEY key, char *value, unsigned long *number) {\r
+ return get_number(key, value, number, true);\r
+}\r
+\r
+int get_parameters(char *service_name, char *exe, unsigned long exelen, char *flags, unsigned long flagslen, char *dir, unsigned long dirlen, char **env, unsigned long *throttle_delay, unsigned long *stop_method, STARTUPINFO *si) {\r
+ unsigned long ret;\r
+\r
/* Get registry */\r
char registry[KEY_LENGTH];\r
- if (_snprintf(registry, sizeof(registry), NSSM_REGISTRY, service_name) < 0) {\r
+ if (_snprintf_s(registry, sizeof(registry), _TRUNCATE, NSSM_REGISTRY, service_name) < 0) {\r
log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, "NSSM_REGISTRY", "get_parameters()", 0);\r
return 1;\r
}\r
/* Try to open the registry */\r
HKEY key;\r
if (RegOpenKeyEx(HKEY_LOCAL_MACHINE, registry, 0, KEY_READ, &key) != ERROR_SUCCESS) {\r
- log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OPENKEY_FAILED, registry, GetLastError(), 0);\r
+ log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OPENKEY_FAILED, registry, error_string(GetLastError()), 0);\r
return 2;\r
}\r
\r
/* Try to get executable file - MUST succeed */\r
- if (expand_parameter(key, NSSM_REG_EXE, exe, exelen)) {\r
+ if (expand_parameter(key, NSSM_REG_EXE, exe, exelen, false)) {\r
RegCloseKey(key);\r
return 3;\r
}\r
\r
/* Try to get flags - may fail and we don't care */\r
- if (expand_parameter(key, NSSM_REG_FLAGS, flags, flagslen)) {\r
+ if (expand_parameter(key, NSSM_REG_FLAGS, flags, flagslen, false)) {\r
log_event(EVENTLOG_WARNING_TYPE, NSSM_EVENT_NO_FLAGS, NSSM_REG_FLAGS, service_name, exe, 0);\r
ZeroMemory(flags, flagslen);\r
}\r
\r
/* Try to get startup directory - may fail and we fall back to a default */\r
- if (expand_parameter(key, NSSM_REG_DIR, dir, dirlen) || ! dir[0]) {\r
+ if (expand_parameter(key, NSSM_REG_DIR, dir, dirlen, true) || ! dir[0]) {\r
/* Our buffers are defined to be long enough for this to be safe */\r
size_t i;\r
for (i = strlen(exe); i && exe[i] != '\\' && exe[i] != '/'; i--);\r
}\r
else {\r
/* Help! */\r
- unsigned long ret = ExpandEnvironmentStrings("%SYSTEMROOT%", dir, dirlen);\r
+ ret = GetWindowsDirectory(dir, dirlen);\r
if (! ret || ret > dirlen) {\r
log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_NO_DIR_AND_NO_FALLBACK, NSSM_REG_DIR, service_name, 0);\r
RegCloseKey(key);\r
log_event(EVENTLOG_WARNING_TYPE, NSSM_EVENT_NO_DIR, NSSM_REG_DIR, service_name, dir, 0);\r
}\r
\r
+ /* Try to get environment variables - may fail */\r
+ set_environment(service_name, key, env);\r
+\r
+ /* Try to get stdout and stderr */\r
+ if (get_output_handles(key, si)) {\r
+ log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_GET_OUTPUT_HANDLES_FAILED, service_name, 0);\r
+ RegCloseKey(key);\r
+ return 5;\r
+ }\r
+\r
+ /* Try to get throttle restart delay */\r
+ unsigned long type = REG_DWORD;\r
+ unsigned long buflen = sizeof(*throttle_delay);\r
+ bool throttle_ok = false;\r
+ ret = RegQueryValueEx(key, NSSM_REG_THROTTLE, 0, &type, (unsigned char *) throttle_delay, &buflen);\r
+ if (ret != ERROR_SUCCESS) {\r
+ if (ret != ERROR_FILE_NOT_FOUND) {\r
+ if (type != REG_DWORD) {\r
+ char milliseconds[16];\r
+ _snprintf_s(milliseconds, sizeof(milliseconds), _TRUNCATE, "%lu", NSSM_RESET_THROTTLE_RESTART);\r
+ log_event(EVENTLOG_WARNING_TYPE, NSSM_EVENT_BOGUS_THROTTLE, service_name, NSSM_REG_THROTTLE, milliseconds, 0);\r
+ }\r
+ else log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_QUERYVALUE_FAILED, NSSM_REG_THROTTLE, error_string(GetLastError()), 0);\r
+ }\r
+ }\r
+ else throttle_ok = true;\r
+\r
+ if (! throttle_ok) *throttle_delay = NSSM_RESET_THROTTLE_RESTART;\r
+\r
+ /* Try to get service stop flags. */\r
+ type = REG_DWORD;\r
+ unsigned long stop_method_skip;\r
+ buflen = sizeof(stop_method_skip);\r
+ bool stop_ok = false;\r
+ ret = RegQueryValueEx(key, NSSM_REG_STOP_METHOD_SKIP, 0, &type, (unsigned char *) &stop_method_skip, &buflen);\r
+ if (ret != ERROR_SUCCESS) {\r
+ if (ret != ERROR_FILE_NOT_FOUND) {\r
+ if (type != REG_DWORD) {\r
+ log_event(EVENTLOG_WARNING_TYPE, NSSM_EVENT_BOGUS_STOP_METHOD_SKIP, service_name, NSSM_REG_STOP_METHOD_SKIP, NSSM, 0);\r
+ }\r
+ else log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_QUERYVALUE_FAILED, NSSM_REG_STOP_METHOD_SKIP, error_string(GetLastError()), 0);\r
+ }\r
+ }\r
+ else stop_ok = true;\r
+\r
+ /* Try all methods except those requested to be skipped. */\r
+ *stop_method = ~0;\r
+ if (stop_ok) *stop_method &= ~stop_method_skip;\r
+\r
/* Close registry */\r
RegCloseKey(key);\r
\r
\r
/* Get registry */\r
char registry[KEY_LENGTH];\r
- if (_snprintf(registry, sizeof(registry), NSSM_REGISTRY "\\%s", service_name, NSSM_REG_EXIT) < 0) {\r
+ if (_snprintf_s(registry, sizeof(registry), _TRUNCATE, NSSM_REGISTRY "\\%s", service_name, NSSM_REG_EXIT) < 0) {\r
log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, "NSSM_REG_EXIT", "get_exit_action()", 0);\r
return 1;\r
}\r
HKEY key;\r
long error = RegOpenKeyEx(HKEY_LOCAL_MACHINE, registry, 0, KEY_READ, &key);\r
if (error != ERROR_SUCCESS && error != ERROR_FILE_NOT_FOUND) {\r
- log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OPENKEY_FAILED, registry, GetLastError(), 0);\r
+ log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OPENKEY_FAILED, registry, error_string(GetLastError()), 0);\r
return 2;\r
}\r
\r
\r
char code[64];\r
if (! ret) code[0] = '\0';\r
- else if (_snprintf(code, sizeof(code), "%lu", *ret) < 0) {\r
+ else if (_snprintf_s(code, sizeof(code), _TRUNCATE, "%lu", *ret) < 0) {\r
RegCloseKey(key);\r
return get_exit_action(service_name, 0, action, default_action);\r
}\r
git://git.iain.cx/iain / nssm.git / blobdiff