int create_messages() {\r
HKEY key;\r
\r
- char registry[MAX_PATH];\r
+ char registry[KEY_LENGTH];\r
if (_snprintf(registry, sizeof(registry), "SYSTEM\\CurrentControlSet\\Services\\EventLog\\Application\\%s", NSSM) < 0) {\r
log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, "eventlog registry", "create_messages()", 0);\r
return 1;\r
\r
int create_parameters(char *service_name, char *exe, char *flags, char *dir) {\r
/* Get registry */\r
- char registry[MAX_PATH];\r
+ char registry[KEY_LENGTH];\r
if (_snprintf(registry, sizeof(registry), NSSM_REGISTRY, service_name) < 0) {\r
log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, "NSSM_REGISTRY", "create_parameters()", 0);\r
return 1;\r
}\r
\r
/* Try to create the parameters */\r
- if (RegSetValueEx(key, NSSM_REG_EXE, 0, REG_SZ, (const unsigned char *) exe, strlen(exe) + 1) != ERROR_SUCCESS) {\r
+ if (RegSetValueEx(key, NSSM_REG_EXE, 0, REG_EXPAND_SZ, (const unsigned char *) exe, strlen(exe) + 1) != ERROR_SUCCESS) {\r
log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_SETVALUE_FAILED, NSSM_REG_EXE, GetLastError(), 0);\r
RegDeleteKey(HKEY_LOCAL_MACHINE, NSSM_REGISTRY);\r
RegCloseKey(key);\r
return 3;\r
}\r
- if (RegSetValueEx(key, NSSM_REG_FLAGS, 0, REG_SZ, (const unsigned char *) flags, strlen(flags) + 1) != ERROR_SUCCESS) {\r
+ if (RegSetValueEx(key, NSSM_REG_FLAGS, 0, REG_EXPAND_SZ, (const unsigned char *) flags, strlen(flags) + 1) != ERROR_SUCCESS) {\r
log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_SETVALUE_FAILED, NSSM_REG_FLAGS, GetLastError(), 0);\r
RegDeleteKey(HKEY_LOCAL_MACHINE, NSSM_REGISTRY);\r
RegCloseKey(key);\r
return 4;\r
}\r
- if (RegSetValueEx(key, NSSM_REG_DIR, 0, REG_SZ, (const unsigned char *) dir, strlen(dir) + 1) != ERROR_SUCCESS) {\r
+ if (RegSetValueEx(key, NSSM_REG_DIR, 0, REG_EXPAND_SZ, (const unsigned char *) dir, strlen(dir) + 1) != ERROR_SUCCESS) {\r
log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_SETVALUE_FAILED, NSSM_REG_DIR, GetLastError(), 0);\r
RegDeleteKey(HKEY_LOCAL_MACHINE, NSSM_REGISTRY);\r
RegCloseKey(key);\r
\r
int create_exit_action(char *service_name, const char *action_string) {\r
/* Get registry */\r
- char registry[MAX_PATH];\r
+ char registry[KEY_LENGTH];\r
if (_snprintf(registry, sizeof(registry), NSSM_REGISTRY "\\%s", service_name, NSSM_REG_EXIT) < 0) {\r
log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, "NSSM_REG_EXIT", "create_exit_action()", 0);\r
return 1;\r
return 0;\r
}\r
\r
+int expand_parameter(HKEY key, char *value, char *data, unsigned long datalen) {\r
+ unsigned char *buffer = (unsigned char *) HeapAlloc(GetProcessHeap(), 0, datalen);\r
+ if (! buffer) {\r
+ log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, value, "expand_parameter()", 0);\r
+ return 1;\r
+ }\r
+\r
+ unsigned long type = REG_EXPAND_SZ;\r
+ unsigned long buflen = datalen;\r
+\r
+ unsigned long ret = RegQueryValueEx(key, value, 0, &type, buffer, &buflen);\r
+ if (ret != ERROR_SUCCESS) {\r
+ if (ret != ERROR_FILE_NOT_FOUND) log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_QUERYVALUE_FAILED, value, GetLastError(), 0);\r
+ HeapFree(GetProcessHeap(), 0, buffer);\r
+ return 2;\r
+ }\r
+\r
+ ZeroMemory(data, datalen);\r
+\r
+ /* Technically we shouldn't expand environment strings from REG_SZ values */\r
+ if (type != REG_EXPAND_SZ) {\r
+ memmove(data, buffer, buflen);\r
+ HeapFree(GetProcessHeap(), 0, buffer);\r
+ return 0;\r
+ }\r
+\r
+ ret = ExpandEnvironmentStrings((char *) buffer, data, datalen);\r
+ if (! ret || ret > datalen) {\r
+ log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_EXPANDENVIRONMENTSTRINGS_FAILED, value, buffer, GetLastError(), 0);\r
+ HeapFree(GetProcessHeap(), 0, buffer);\r
+ return 3;\r
+ }\r
+\r
+ HeapFree(GetProcessHeap(), 0, buffer);\r
+ return 0;\r
+}\r
+\r
int get_parameters(char *service_name, char *exe, int exelen, char *flags, int flagslen, char *dir, int dirlen) {\r
/* Get registry */\r
- char registry[MAX_PATH];\r
+ char registry[KEY_LENGTH];\r
if (_snprintf(registry, sizeof(registry), NSSM_REGISTRY, service_name) < 0) {\r
log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, "NSSM_REGISTRY", "get_parameters()", 0);\r
return 1;\r
return 2;\r
}\r
\r
- unsigned long type = REG_SZ;\r
-\r
/* Try to get executable file - MUST succeed */\r
- if (RegQueryValueEx(key, NSSM_REG_EXE, 0, &type, (unsigned char *) exe, (unsigned long *) &exelen) != ERROR_SUCCESS) {\r
- log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_QUERYVALUE_FAILED, NSSM_REG_EXE, GetLastError(), 0);\r
+ if (expand_parameter(key, NSSM_REG_EXE, exe, exelen)) {\r
RegCloseKey(key);\r
return 3;\r
}\r
\r
- /* Try to get flags - may fail */\r
- if (RegQueryValueEx(key, NSSM_REG_FLAGS, 0, &type, (unsigned char *) flags, (unsigned long *) &flagslen) != ERROR_SUCCESS) {\r
- log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_QUERYVALUE_FAILED, NSSM_REG_FLAGS, GetLastError(), 0);\r
- RegCloseKey(key);\r
- return 4;\r
- }\r
-\r
- /* Try to get startup directory - may fail */\r
- if (RegQueryValueEx(key, NSSM_REG_DIR, 0, &type, (unsigned char *) dir, (unsigned long *) &dirlen) != ERROR_SUCCESS) {\r
- log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_QUERYVALUE_FAILED, NSSM_REG_DIR, GetLastError(), 0);\r
- RegCloseKey(key);\r
- return 5;\r
+ /* Try to get flags - may fail and we don't care */\r
+ if (expand_parameter(key, NSSM_REG_FLAGS, flags, flagslen)) {\r
+ log_event(EVENTLOG_WARNING_TYPE, NSSM_EVENT_NO_FLAGS, NSSM_REG_FLAGS, service_name, exe, 0);\r
+ ZeroMemory(flags, flagslen);\r
+ }\r
+\r
+ /* Try to get startup directory - may fail and we fall back to a default */\r
+ if (expand_parameter(key, NSSM_REG_DIR, dir, dirlen) || ! dir[0]) {\r
+ /* Our buffers are defined to be long enough for this to be safe */\r
+ size_t i;\r
+ for (i = strlen(exe); i && exe[i] != '\\' && exe[i] != '/'; i--);\r
+ if (i) {\r
+ memmove(dir, exe, i);\r
+ dir[i] = '\0';\r
+ }\r
+ else {\r
+ /* Help! */\r
+ unsigned long ret = ExpandEnvironmentStrings("%SYSTEMROOT%", dir, dirlen);\r
+ if (! ret || ret > dirlen) {\r
+ log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_NO_DIR_AND_NO_FALLBACK, NSSM_REG_DIR, service_name, 0);\r
+ RegCloseKey(key);\r
+ return 4;\r
+ }\r
+ }\r
+ log_event(EVENTLOG_WARNING_TYPE, NSSM_EVENT_NO_DIR, NSSM_REG_DIR, service_name, dir, 0);\r
}\r
\r
/* Close registry */\r
return 0;\r
}\r
\r
-int get_exit_action(char *service_name, unsigned long *ret, unsigned char *action) {\r
+int get_exit_action(char *service_name, unsigned long *ret, unsigned char *action, bool *default_action) {\r
+ /* Are we returning the default action or a status-specific one? */\r
+ *default_action = ! ret;\r
+\r
/* Get registry */\r
- char registry[MAX_PATH];\r
+ char registry[KEY_LENGTH];\r
if (_snprintf(registry, sizeof(registry), NSSM_REGISTRY "\\%s", service_name, NSSM_REG_EXIT) < 0) {\r
log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, "NSSM_REG_EXIT", "get_exit_action()", 0);\r
return 1;\r
if (! ret) code[0] = '\0';\r
else if (_snprintf(code, sizeof(code), "%lu", *ret) < 0) {\r
RegCloseKey(key);\r
- return get_exit_action(service_name, 0, action);\r
+ return get_exit_action(service_name, 0, action, default_action);\r
}\r
if (RegQueryValueEx(key, code, 0, &type, action, &action_len) != ERROR_SUCCESS) {\r
RegCloseKey(key);\r
/* Try again with * as the key if an exit code was defined */\r
- if (ret) return get_exit_action(service_name, 0, action);\r
+ if (ret) return get_exit_action(service_name, 0, action, default_action);\r
return 0;\r
}\r
\r
git://git.iain.cx/iain / nssm.git / blobdiff